Re: Feedback on updated NOTICE and LICENSE files (was: [VOTE] Release Kafka 0.7.0-incubating)

On Dec 1, 2011, at 12:55 PM, Neha Narkhede wrote:

>>> As it stands, either the NOTICE file is wrong, or the LICENSE file is
> wrong, because the NOTICE file should not mention 3rd party products
> that are not in the LICENSE file.
>
> Thanks for the feedback! As I have already mentioned, we are tracking a bug
> to fix all non-blocker changes to the NOTICE file for the next release.
> I will include this feedback there.
>
> Correct me if I understood the long discussions on this list, but I don't
> think this blocks the current release.

My point would be that it's very likely that your LICENSE file is incorrect (i.e. it is missing necessary license information).

So far, the only LICENSE file changes that have been made are the explicit issues that have been pointed out to you. I think the Kafka community needs to review all of their artifacts and make sure that their licenses/notices are accurately documented in the LICENSE (and NOTICE). I don't see any evidence that the community has attempted to do this.

I think the artifacts that need to be reviewed are:

./clients/csharp/lib/nunit/2.5.9/nunit.framework.dll
./contrib/hadoop-consumer/lib/avro-1.4.0.jar
./contrib/hadoop-consumer/lib/commons-logging-1.0.4.jar
./contrib/hadoop-consumer/lib/hadoop-0.20.2-core.jar
./contrib/hadoop-consumer/lib/jackson-core-asl-1.5.5.jar
./contrib/hadoop-consumer/lib/jackson-mapper-asl-1.5.5.jar
./contrib/hadoop-consumer/lib/pig-0.8.0-core.jar
./contrib/hadoop-consumer/lib/piggybank.jar
./contrib/hadoop-consumer/lib_managed/scala_2.8.0/compile/commons-codec-1.2.jar
./contrib/hadoop-consumer/lib_managed/scala_2.8.0/compile/commons-httpclient-3.1.jar
./contrib/hadoop-consumer/lib_managed/scala_2.8.0/compile/commons-logging-1.0.4.jar
./contrib/hadoop-consumer/lib_managed/scala_2.8.0/compile/joda-time-1.6.jar
./contrib/hadoop-consumer/lib_managed/scala_2.8.0/compile/jopt-simple-3.2.jar
./contrib/hadoop-consumer/lib_managed/scala_2.8.0/compile/log4j-1.2.15.jar
./contrib/hadoop-consumer/target/scala_2.8.0/hadoop-consumer_2.8.0-0.7.0.jar
./contrib/hadoop-producer/lib/avro-1.4.0.jar
./contrib/hadoop-producer/lib/commons-logging-1.0.4.jar
./contrib/hadoop-producer/lib/hadoop-0.20.2-core.jar
./contrib/hadoop-producer/lib/jackson-core-asl-1.5.5.jar
./contrib/hadoop-producer/lib/jackson-mapper-asl-1.5.5.jar
./contrib/hadoop-producer/lib/pig-0.8.0-core.jar
./contrib/hadoop-producer/lib/piggybank.jar
./contrib/hadoop-producer/lib_managed/scala_2.8.0/compile/ant-1.7.1.jar
./contrib/hadoop-producer/lib_managed/scala_2.8.0/compile/ant-launcher-1.7.1.jar
./contrib/hadoop-producer/lib_managed/scala_2.8.0/compile/asm-3.2.jar
./contrib/hadoop-producer/lib_managed/scala_2.8.0/compile/avro-1.4.1.jar
./contrib/hadoop-producer/lib_managed/scala_2.8.0/compile/commons-collections-3.2.1.jar
./contrib/hadoop-producer/lib_managed/scala_2.8.0/compile/commons-lang-2.5.jar
./contrib/hadoop-producer/lib_managed/scala_2.8.0/compile/jackson-core-asl-1.5.5.jar
./contrib/hadoop-producer/lib_managed/scala_2.8.0/compile/jackson-mapper-asl-1.5.5.jar
./contrib/hadoop-producer/lib_managed/scala_2.8.0/compile/jetty-6.1.22.jar
./contrib/hadoop-producer/lib_managed/scala_2.8.0/compile/jetty-util-6.1.22.jar
./contrib/hadoop-producer/lib_managed/scala_2.8.0/compile/jopt-simple-3.2.jar
./contrib/hadoop-producer/lib_managed/scala_2.8.0/compile/log4j-1.2.15.jar
./contrib/hadoop-producer/lib_managed/scala_2.8.0/compile/oro-2.0.8.jar
./contrib/hadoop-producer/lib_managed/scala_2.8.0/compile/paranamer-2.2.jar
./contrib/hadoop-producer/lib_managed/scala_2.8.0/compile/paranamer-ant-2.2.jar
./contrib/hadoop-producer/lib_managed/scala_2.8.0/compile/paranamer-generator-2.2.jar
./contrib/hadoop-producer/lib_managed/scala_2.8.0/compile/qdox-1.10.1.jar
./contrib/hadoop-producer/lib_managed/scala_2.8.0/compile/servlet-api-2.5-20081211.jar
./contrib/hadoop-producer/lib_managed/scala_2.8.0/compile/slf4j-api-1.5.11.jar
./contrib/hadoop-producer/lib_managed/scala_2.8.0/compile/velocity-1.6.4.jar
./contrib/hadoop-producer/target/scala_2.8.0/hadoop-producer_2.8.0-0.7.0.jar
./core/lib/zkclient-20110412.jar
./core/lib_managed/scala_2.8.0/compile/jopt-simple-3.2.jar
./core/lib_managed/scala_2.8.0/compile/log4j-1.2.15.jar
./core/lib_managed/scala_2.8.0/compile/zookeeper-3.3.3.jar
./core/target/scala_2.8.0/kafka-0.7.0.jar
./examples/lib_managed/scala_2.8.0/compile/jopt-simple-3.2.jar
./examples/lib_managed/scala_2.8.0/compile/log4j-1.2.15.jar
./examples/target/scala_2.8.0/kafka-java-examples-0.7.0.jar
./kafka-0.7.0.jar
./lib/apache-rat-0.8-SNAPSHOT.jar
./lib/sbt-launch.jar
./project/boot/scala-2.8.0/lib/scala-compiler.jar
./project/boot/scala-2.8.0/lib/scala-library.jar

I took a quick look at some of these artifacts. I definitely see licenses missing from the LICENSE file. For example:

paranamer-2.2.jar -- http://paranamer.codehaus.org/info/license.html
sbt-launch.jar -- has 4 license files -- license, licenses/LICENSE_Scala, licenses/LICENSE_Apache, licenses/LICENSE_JLine (2 are missing from your LICENSE)
hadoop -- has a unique license for the org.apache.hadoop.util.bloom.* classes.

I don't know how many other problems there are… I'm sorry, but I don't have time to generate this information for you (nor should I need to). This is something the Kafka community needs to take on.

Please note that these are just the problems that I noticed. Someone should document the licenses (and notice files) for each of your artifacts. Then use this information to generate Kafka LICENSE/NOTICE files using this information.

--kevan
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org